-
Notifications
You must be signed in to change notification settings - Fork 36
add public-viewer support to pkg/log #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this commit is part of PR codeready-toolchain#443 Signed-off-by: Francesco Ilario <filario@redhat.com>
this commit is part of PR codeready-toolchain#443 Signed-off-by: Francesco Ilario <filario@redhat.com>
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 78.56% 78.59% +0.03%
==========================================
Files 42 42
Lines 2696 2700 +4
==========================================
+ Hits 2118 2122 +4
Misses 487 487
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, filariow, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is part of the effort of splitting PR #443
Requires the following PRs to be merged