Skip to content

add public-viewer support to pkg/log #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Jul 25, 2024

This PR is part of the effort of splitting PR #443

Requires the following PRs to be merged

filariow added 2 commits July 25, 2024 14:53
this commit is part of PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
this commit is part of PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
Copy link

openshift-ci bot commented Jul 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (007cba6) to head (3ff55d9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   78.56%   78.59%   +0.03%     
==========================================
  Files          42       42              
  Lines        2696     2700       +4     
==========================================
+ Hits         2118     2122       +4     
  Misses        487      487              
  Partials       91       91              
Flag Coverage Δ
unittests 78.59% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filariow filariow mentioned this pull request Jul 25, 2024
7 tasks
Copy link

Copy link

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@filariow filariow merged commit b123fb6 into codeready-toolchain:master Aug 5, 2024
10 of 11 checks passed
@filariow filariow deleted the pv-532-log branch August 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants